Merged
Conversation
GhilesA
reviewed
Jan 20, 2026
GhilesA
left a comment
GhilesA
left a comment
There was a problem hiding this comment.
Best solution for now. As discussed:
- a more robust solution will require refactoring and improving the existing code -> this will be evaluated later.
- the current CPU consumption makes this quick fix necessary in the short term.
| // Nothing to do | ||
| try { | ||
| while (!writer.isConsumerFinished()) { | ||
| Thread.sleep(100); |
There was a problem hiding this comment.
Quick and dirty but accepted for the current fix
antoinebhs
approved these changes
Jan 20, 2026
Contributor
antoinebhs
left a comment
antoinebhs
left a comment
There was a problem hiding this comment.
Code OK awaiting for a better solution
jonenst
force-pushed
the
refactorwritertests
branch
from
4ac1757 to
64c1314
Compare
…l to avoid 100%cpu This runs for about 5s at 100% during normal a big analysis.
jonenst
force-pushed
the
writer_poll_sleep
branch
2 times, most recently
from
e4a857c to
49ba5c7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Go easier on the cpu during the ending poll when writing results